-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decrease number of messages from MoveToFort worker #4745
Conversation
@cmezh, thanks for your PR! By analyzing the annotation information on this pull request, we identified @douglascamata and @cwild to be potential reviewers |
I actually like having this info, so I know the bot's doing something at times when nothing else is happening. |
@Gobberwart If you take look at timestamp and wait 0.5-2 seconds you can see that it's working ;) |
@cmezh OK, that's kinda cool actually (I misunderstood your intention). Any chance of putting this in follow_path and follow_spiral as well? Follow_path drives me mental with its constant waffle about which geographic coordinate it's moving to. Would be great to have this limited. |
@Gobberwart Yep, why not? But first this idea and its implementation must be approved by devs. |
Looking forward to seeing the end result of this. |
@Gobberwart @cmezh Love it. When we expand, can we add to config to set frequency? Maybe ever X events we print, or by distance, etc. Maybe just an enable/disable - sometimes I like to see each for testing walker changes. |
If we go this way, I think, enable/disable is enough. Maybe I will 26 авг. 2016 г. 21:56 пользователь "Matt J Madsen" notifications@github.com
|
Working on a PR, should be up shortly. |
@mjmadsen Nice! Sorry, I forgot that you are dev and started explaining simple things 8) |
config attribute isn't passed to the event manager, or I'm missing something. Might take me a bit longer than I expected. |
Overwrite previous event line (only moving_to_fort and moving_to_lured_fort events).