Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease number of messages from MoveToFort worker #4745

Merged
merged 1 commit into from
Aug 26, 2016
Merged

Decrease number of messages from MoveToFort worker #4745

merged 1 commit into from
Aug 26, 2016

Conversation

cmezh
Copy link
Contributor

@cmezh cmezh commented Aug 25, 2016

Overwrite previous event line (only moving_to_fort and moving_to_lured_fort events).

@mention-bot
Copy link

@cmezh, thanks for your PR! By analyzing the annotation information on this pull request, we identified @douglascamata and @cwild to be potential reviewers

@Gobberwart
Copy link
Contributor

Gobberwart commented Aug 26, 2016

I actually like having this info, so I know the bot's doing something at times when nothing else is happening.

@cmezh
Copy link
Contributor Author

cmezh commented Aug 26, 2016

@Gobberwart If you take look at timestamp and wait 0.5-2 seconds you can see that it's working ;)
Also I've changed in my config "distance_unit" to "m" instead of "km", so now messages are not the same.

@Gobberwart
Copy link
Contributor

Gobberwart commented Aug 26, 2016

@cmezh OK, that's kinda cool actually (I misunderstood your intention). Any chance of putting this in follow_path and follow_spiral as well?

Follow_path drives me mental with its constant waffle about which geographic coordinate it's moving to. Would be great to have this limited.

@cmezh
Copy link
Contributor Author

cmezh commented Aug 26, 2016

@Gobberwart Yep, why not? But first this idea and its implementation must be approved by devs.

@Gobberwart
Copy link
Contributor

Looking forward to seeing the end result of this.

@mjmadsen
Copy link
Contributor

@Gobberwart @cmezh Love it. When we expand, can we add to config to set frequency? Maybe ever X events we print, or by distance, etc. Maybe just an enable/disable - sometimes I like to see each for testing walker changes.

@cmezh
Copy link
Contributor Author

cmezh commented Aug 26, 2016

If we go this way, I think, enable/disable is enough. Maybe I will
implement this.
Currently you can disable this feature if you set debug option in
config to true. But in this case you will also get other debugging
messages, not only from MoveToFort.

26 авг. 2016 г. 21:56 пользователь "Matt J Madsen" notifications@github.com
написал:

@Gobberwart https://github.com/Gobberwart @cmezh
https://github.com/cmezh Love it. When we expand, can we add to config
to set frequency? Maybe ever X events we print, or by distance, etc. Maybe
just an enable/disable - sometimes I like to see each for testing walker
changes.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4745 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATxdtcZeFyIozcbNWMAEPiuxJHXPztvUks5qjzPNgaJpZM4Jtnfk
.

@mjmadsen
Copy link
Contributor

Working on a PR, should be up shortly.

@cmezh
Copy link
Contributor Author

cmezh commented Aug 26, 2016

@mjmadsen Nice! Sorry, I forgot that you are dev and started explaining simple things 8)

@mjmadsen
Copy link
Contributor

config attribute isn't passed to the event manager, or I'm missing something. Might take me a bit longer than I expected.

@mjmadsen mjmadsen mentioned this pull request Aug 26, 2016
@mjmadsen
Copy link
Contributor

@cmezh Check out #4780 - I need to do some minor things before it can be merged.

solderzzc added a commit that referenced this pull request Aug 26, 2016
@Gobberwart
Copy link
Contributor

Looking good! I've only tested with MoveToFort but I'm really liking it. Nice work @cmezh and @mjmadsen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants